FEATURE: Nested components#32
Open
dkaoster wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #31
TYPE OF CHANGE
After some discussion and testing on our end, we've decided to go with this approach to solve the issues outlined in #31. Specifically, we modified this repo to allow for a nested hierarchy when creating elements based on data.
PROBLEM
Sometimes, we would like for our datasets to generate svg elements more than a single node. For instance, we may want to wrap a rect with an anchor, or include text with a shape.
SOLUTION
The solution is to allow components to be nested. That way, we can use something like
NOTES
This should be fully backward compatible with the current API and introduce this feature with no breaking changes.